Fix category search in explore #6093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Everything works in @nicolas-raoul your thoughts? |
|
Eon't worry about beta, that fix is more urgent. Can you create a different issue about what's not working in beta? Is it still a draft? 🙂 |
|
Okay, I just kept it as the draft because of that, will mark it as ready now. |
Signed-off-by: parneet-guraya <[email protected]>
parneet-guraya
force-pushed
the
fix-search
branch
from
73075a7 to
b6d38a4
Compare
misaochan
approved these changes
Jan 3, 2025
|
@parneet-guraya Next time try to have the PR description in the following format (note the lack of new lines): This will ensure the issues are closed automatically when the PR is merged. Thanks! 🙂 |
sivaraam
added a commit
that referenced
this pull request
Jan 15, 2025
This is a change that replicates the fix done via PR #6093. This is based over v5.1.1 as the fix seems necessary for the category search to work properly on the explore screen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
#6043
#5910
Tests performed (required)
Tested in
prodDebugScreenshots (for UI changes only)
Record_2024-12-31-02-15-42.mp4