Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit content of unexpected stderr #149

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Emit content of unexpected stderr #149

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions nbval/plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,12 +481,18 @@ def compare_outputs(self, test, ref, skip_compare=None):
)
return False
elif test_keys - ref_keys:
extra_keys = test_keys - ref_keys
self.comparison_traceback.append(
cc.FAIL
+ "Unexpected output fields from running code: %s"
% (test_keys - ref_keys)
+ "Unexpected output fields from running code: %s" % extra_keys
+ cc.ENDC
)
+ "<<<<<<<<<<<< Unexpected content:"
+ "\n".join("%s: %s" % (i, testing_outs[i]) for i in extra_keys)
+ cc.FAIL
+ '>>>>>>>>>>>>'
+ cc.ENDC
)
print('IN STDERR WE GOT: %s' % testing_outs['stderr'])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this ALLCAPS print statement meant to be kept in?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uoops no! that's clearly a leftover. Pushing a fix+rebase shortly

return False

# If we've got to here, the two dicts must have the same set of keys
Expand Down