Fix build issue with ICPC when using CGAL #25843
Open
+11
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The original code was adding "-fp-model strict" to all targets Regardless of the language which led to compilation issues with CMake Project that contained CUDA or C code (untesed with C). Change fp-model strict to fp-model=strict for more compatibility with Wrappers like nvcc. Relevant intel doc: https://www.intel.com/content/www/us/en/docs/cpp-compiler/developer-guide-reference/2021-8/fp-model-fp.html
Marc-Pierre-Barbier
force-pushed
the
master
branch
from
51f2272 to
f56f892
Compare
|
Asking @jcar87 to take a look at this :) |
|
Hi @Marc-Pierre-Barbier. The CGAL project does not officially support the Intel Compiler, but tries to improve the support for non-tested compilers anyway. Should not this fix be contributed upstream, so that it applies also to CGAL versions 6.0 or later? |
I saw the cmake code in the conanfile and thought it came from here, but if it came from upstream then I will create a pr there too. |
Marc-Pierre-Barbier
pushed a commit
to Marc-Pierre-Barbier/cgal
that referenced
this pull request
Nov 27, 2024
Related to conan's conan-io/conan-center-index#25843 replaced 'fp-model strict' by 'fp-model=strict' https://www.intel.com/content/www/us/en/docs/cpp-compiler/developer-guide-reference/2021-8/fp-model-fp.html for more compatibility with nvcc. as 'fp-model=strict' will be directly transmited to the compiler while 'fp-model strict' will have 'strict' being treated as a file input. Also added a CXX only filter for newer cmake 3.3+
Marc-Pierre-Barbier
pushed a commit
to Marc-Pierre-Barbier/cgal
that referenced
this pull request
Nov 27, 2024
Related to conan's conan-io/conan-center-index#25843 replaced 'fp-model strict' by 'fp-model=strict' https://www.intel.com/content/www/us/en/docs/cpp-compiler/developer-guide-reference/2021-8/fp-model-fp.html for more compatibility with nvcc. as 'fp-model=strict' will be directly transmited to the compiler while 'fp-model strict' will have 'strict' being treated as a file input. Also added a CXX only filter for newer cmake 3.3+
|
i just opened a pr upstream with the changes. |
sloriot
added a commit
to CGAL/cgal
that referenced
this pull request
Dec 4, 2024
## Summary of Changes Related to conan's conan-io/conan-center-index#25843 replaced 'fp-model strict' by 'fp-model=strict' https://www.intel.com/content/www/us/en/docs/cpp-compiler/developer-guide-reference/2021-8/fp-model-fp.html for more compatibility with nvcc. as 'fp-model=strict' will be directly transmited to the compiler while 'fp-model strict' will have 'strict' being treated as a file input. Also added a CXX only filter for newer cmake 3.3+ _Please use the following template to help us managing pull requests._ ## Release Management * Affected package(s): at least conan
|
The Upstream pr has been merged! |
lrineau
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The original code was adding "-fp-model strict" to all targets Regardless of the language which led to compilation issues with CMake Project that contained CUDA or C code (untesed with C).
Motivation
This issue made my cuda builds fail.
I didn't open an issue, as the work required to create a detailed issue is the same as fixing it directly.
Details
I simply repeated what was already done for other compilers but applied it to intel.
I didn't test on Windows or using older CMAKE <3.3, so be careful with the review.
As the conditions are copied and pasted from the other compilers and the linux & cmake > 3.3 test worked well. I believe it should work.
I also changed "fp-model strict" to "fp-model=strict" for more compatibility with Wrappers like nvcc which can transmit unknown arguments to the underlying compiler.
Relevant intel doc: https://www.intel.com/content/www/us/en/docs/cpp-compiler/developer-guide-reference/2021-8/fp-model-fp.html