Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[xnnpack] bump version #7856

Merged
merged 3 commits into from
Oct 30, 2021
Merged

[xnnpack] bump version #7856

merged 3 commits into from
Oct 30, 2021

Conversation

planetmarshall
Copy link
Contributor

Specify library name and version: xnnpack/cci.20211026

  • Updates xnnpack to latest version which means xnnpack support can be added to the tensorflow-lite recipe (see [tensorflow-lite] Add recipe #7855)
  • Switch to tarball downloads which are about 40% of the zipfile size
  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot conan-center-bot added the Bump version PR bumping version without recipe modifications label Oct 27, 2021
@prince-chrismc prince-chrismc mentioned this pull request Oct 27, 2021
Open
Croydon
Croydon previously approved these changes Oct 27, 2021
View reviewed changes
@planetmarshall
Copy link
Contributor Author

Failing on cross compilation for arm due to CMAKE_SYSTEM_PROCESSOR is not defined - is conan not supposed to set this value?

@SSE4
Copy link
Contributor

SSE4 commented Oct 28, 2021

Failing on cross compilation for arm due to CMAKE_SYSTEM_PROCESSOR is not defined - is conan not supposed to set this value?

yes, sometimes conan is unable to deduce the value of CMAKE_SYSTEM_PROCESSOR properly, see an ongoing discussion for the details: conan-io/conan#8026

@conan-center-bot conan-center-bot removed the Bump version PR bumping version without recipe modifications label Oct 28, 2021
@conan-center-bot
Copy link
Collaborator

All green in build 3 (3ab42cb031a5a1a5fe9b1042d651c7adc59d7e0e):

  • xnnpack/cci.20210310@:
    All packages built successfully! (All logs)

  • xnnpack/cci.20211026@:
    All packages built successfully! (All logs)

uilianries
uilianries approved these changes Oct 29, 2021
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit bec75c8 into conan-io:master Oct 30, 2021
ivanvurbanov pushed a commit to ivanvurbanov/conan-center-index that referenced this pull request Dec 2, 2021
@planetmarshall @ivanvurbanov
(conan-io#7856) [xnnpack] bump version
254de50 
* [xnnpack] bump version

* [xnnpack] use tarball downloads

* [xnnpack] define CMAKE_SYSTEM_PROCESSOR for Apple M1
@planetmarshall planetmarshall deleted the xnnpack-update branch March 4, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SSE4 SSE4 SSE4 approved these changes

@madebr madebr madebr approved these changes

@uilianries uilianries uilianries approved these changes

@Croydon Croydon Croydon left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@planetmarshall @SSE4 @conan-center-bot @Croydon @madebr @uilianries