Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Move all configure-related methods to a function #6951

Merged
merged 3 commits into from
May 4, 2020

Conversation

jgsogo
Copy link
Contributor

@jgsogo jgsogo commented May 4, 2020

Changelog: omit
Docs: omit

This PR moves all the config, config_options and configure calls into a function run_configure_method. In this function I'll implement the try/catch for the new build-exception:

  1. it keeps exactly the same logic from graph_builder.py (logic from _config_node function)
  2. it adds calls to for logic under load_consumer_conanfile function.

IMO it is safe to introduce (2) as it is introducing calls to config() (which is already deprecated and I don't know any recipe using it) and another call to conanfile.options.propagate_upstream but it will execute nothing as all its arguments are None.


I can keep existing behavior, but I prefer not to add an if/else to this new run_configure_method function.

@jgsogo jgsogo added this to the 1.26 milestone May 4, 2020
@jgsogo jgsogo requested a review from czoido May 4, 2020 14:51
@memsharded memsharded merged commit ddf9cca into conan-io:develop May 4, 2020
@jgsogo jgsogo deleted the feat/exception-build-refact branch May 4, 2020 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants