configuration section and download cache docs #1544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danimtb
requested changes
Feb 4, 2020
There was a problem hiding this comment.
Some minor changes and some questions that maybe help to detail the explanation a little bit more:
- Cache the download cache path to reuse in different builds?
- Point it to a folder inside
.conanfolder?
Other questions:
- Does this have something to do with the
short_pathsfeature on windows? - Are files copied to the Conan cache as usual or are these paths used instead?
jgsogo
suggested changes
Feb 4, 2020
There was a problem hiding this comment.
I expected this to be a short section, maybe one-two paragraphs: it is a cache, it is an optimization, it should be transparent for the user to use, no need to know about the internals. For me, it would be enough to have a brief explanation of the purpose, how to activate/deactivate it (and remove), and the warnings
..but let's hear the feedback from other reviewers
Co-Authored-By: Daniel <[email protected]>
Co-Authored-By: Daniel <[email protected]>
Co-Authored-By: Daniel <[email protected]>
Co-Authored-By: Daniel <[email protected]>
Co-Authored-By: Daniel <[email protected]>
Co-Authored-By: Daniel <[email protected]>
Co-Authored-By: Daniel <[email protected]>
Co-Authored-By: Daniel <[email protected]>
danimtb
approved these changes
Feb 4, 2020
czoido
approved these changes
Feb 4, 2020
jgsogo
suggested changes
Feb 4, 2020
Co-Authored-By: Javier G. Sogo <[email protected]>
Co-Authored-By: Javier G. Sogo <[email protected]>
|
Done, removed some implementation details, added note about proxies, and merged some suggestions. |
jgsogo
approved these changes
Feb 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs for conan-io/conan#6287