Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Fix test running with python 2 #146

Closed
danimtb opened this issue Jan 17, 2020 · 1 comment · Fixed by #147
Closed

[CI] Fix test running with python 2 #146

danimtb opened this issue Jan 17, 2020 · 1 comment · Fixed by #147
Assignees
@uilianries

Comments

@danimtb
Copy link
Member

danimtb commented Jan 17, 2020

In the development version of conan (1.22), python 2 is deprecated on purpose.

We should set USE_UNSUPPORTED_CONAN_WITH_PYTHON_2 variable in the CI for Conan dev > 1.21.X

Related to #145
@danimtb danimtb mentioned this issue Jan 17, 2020
Open
@jgsogo
Copy link
Contributor

jgsogo commented Jan 18, 2020

Add it to the .travis.yml and appveyor.yml files in the entries for current conandev (we will need to move it when rolling releases, but eventually it will disappear), IMO it is better than adding it to the actual testing sources

uilianries added a commit to uilianries/hooks that referenced this issue Jan 20, 2020
@uilianries
conan-io#146 Fix py2 support
646c7d0 
Signed-off-by: Uilian Ries <[email protected]>
@uilianries uilianries mentioned this issue Jan 20, 2020
Merged
uilianries added a commit to uilianries/hooks that referenced this issue Jan 20, 2020
@uilianries
conan-io#146 Pass env var through tox
2c8bbc3 
Signed-off-by: Uilian Ries <[email protected]>
uilianries added a commit to uilianries/hooks that referenced this issue Jan 20, 2020
@uilianries
conan-io#146 Pass env var through tox
552b440 
Signed-off-by: Uilian Ries <[email protected]>
danimtb added a commit that referenced this issue Jan 27, 2020
@danimtb
Merge pull request #147 from uilianries/hotfix/python2
c363534 
#146 Fix py2 support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@uilianries uilianries

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#146 Fix py2 support uilianries/hooks
3 participants
@jgsogo @uilianries @danimtb