-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build for windows with CMake #16
base: main
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@isuruf: Any idea what I did wrong so that appveyor does not run anymore? |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
Thanks for the comments :) |
|
I start to wonder whether we should actually use the Windows ZIP at all… |
The Windows ZIP does not ship |
@isuruf: Do you understand the issue on macOS?
I added |
@isuruf: Since I don't really know how this Windows stuff works. How would I tell the system where to find
|
Use the cmake script, cmake_minimum_required(VERSION 3.6)
project(ntl)
find_library(GMP_LIBRARY NAMES gmp)
find_path(GMP_INCLUDE_DIR NAMES gmp.h)
find_library(GF2X_LIBRARY NAMES gf2x)
find_path(GF2X_INCLUDE_DIR NAMES gf2x.h)
file(GLOB SOURCES src/*.cpp)
add_library(${PROJECT_NAME} SHARED ${SOURCES})
target_include_directories(ntl include ${GMP_INCLUDE_DIR} ${GF2X_INCLUDE_DIR})
target_link_libraries(ntl ${GMP_LIBRARY} ${GF2X_LIBRARY})
install(TARGETS ${PROJECT_NAME}
RUNTIME DESTINATION bin
ARCHIVE DESTINATION lib
LIBRARY DESTINATION lib)
file(GLOB HEADERS include/NTL/*.h)
install(FILES ${HEADERS} DESTINATION include/NTL) and add |
Btw, why not keep the CMakeLists.txt as a regular file in the recipe and copy it over? Changing it as a patch is more work. |
…nda-forge-pinning 2024.01.05.22.51.09
@conda-forge-admin, rerender |
…onda-forge-pinning 2024.12.05.23.59.20
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe/meta.yaml:
For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12200640822. Examine the logs at this URL for more detail. |
@conda-forge-admin, rerender |
…onda-forge-pinning 2024.12.06.08.06.51
@conda-forge-admin rerender |
@conda-forge-admin rerender |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hi! This is the friendly automated conda-forge-linting service. I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12200819769. Examine the logs at this URL for more detail. |
…onda-forge-pinning 2024.12.06.08.06.51
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Static libraries are built fine now. One test failure though. |
Would it be perhaps possible to patch this one failing test for now? An imperfect build is still better than no build, in my book ;) |
@conda-forge-admin rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12733063721. Examine the logs at this URL for more detail. |
NTL provides zip file with some changes to its source code to make
Windows happy. However, they don't provide any build system but refer
people to some creative clicking in Visual Studio.