Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

illumos support #31

Closed
papertigers opened this issue Sep 2, 2019 · 2 comments
Closed

illumos support #31

papertigers opened this issue Sep 2, 2019 · 2 comments

Comments

@papertigers
Copy link

I have had dcuddeback/termios-rs#21 open on termios-rs for 7 months and it doesn't look there has been any activity for almost a year on that repo. It's been a pain to deal with anything on illumos/solaris that uses console due to the need to point Cargo.toml at my custom version. Would you be opposed to a PR that changes the unix dependency on termios-rs to point to a fork of that repo with my change for illumos/solaris and leave all other unix's pointing at the official repo. One example of where dealing with this has been painful is when building "bat".

@mitsuhiko
Copy link
Collaborator

@papertigers i would be happy to just add whatever we need form termios into this crate. Can't be that much code.

@papertigers
Copy link
Author

termios changes got merged. Closing

dtolnay pushed a commit to dtolnay-contrib/console that referenced this issue Feb 4, 2022
Currently, the console subscriber will store task data for tasks even
after they complete. This means that it will use an increasing amount of
memory over time. This branch updates the aggregator task to drop data
for completed spans after a configurable retention period.

I've also added a builder for configuring the console subscriber, including
changing the retention period. By default, completed tasks are retained for
an hour, so that some historical data can be played back, but this can be
reduced to decrease memory usage.

Signed-off-by: Eliza Weisman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants