Dep Support #93
Merged
Dep Support #93
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes issue container-storage-interface#91 by adding support for the official Go dependency tool, Dep. The solution is a nearly-empty Go source file at "lib/go/csi.go" that defines a package with no functional code. However, this package will enable the ability to nil-import "github.com/container-storage-interface/spec/lib/go" so that the Dep tool discovers a valid Go package (a directory with one or more Go sources in it). For information on why the resolution is not to simply import "github.com/container-storage-interface/spec/lib/go/csi" please see issue container-storage-interface#91.
|
LGTM! |
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes issue #91 by adding support for the official Go dependency tool, Dep. The solution is a nearly-empty Go source file at
lib/go/csi.gothat defines a package with no functional code. However, this package will enable the ability to nil-importgithub.lhy31512.workers.dev/container-storage-interface/spec/lib/goso that the Dep tool discovers a valid Go package (a directory with one or more Go sources in it).For information on why the resolution is not to simply import
github.com/container-storage-interface/spec/lib/go/csiplease see issue #91.