umd build #108
Merged
umd build #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 17, 2017
Closed
axe312ger
reviewed
Feb 2, 2017
.travis.yml
Outdated
| @@ -4,10 +4,9 @@ before_install: | |||
| - npm set progress=false | |||
| language: node_js | |||
| node_js: | |||
| - "6.0" | |||
There was a problem hiding this comment.
we may already consider node 7?
There was a problem hiding this comment.
the aim is to support the lts versions https://cloud.githubusercontent.com/assets/1156093/16716136/32f18fa6-46f4-11e6-8d56-3619807d38ad.png
|
Changes Unknown when pulling 026c440 on umb-build into ** on master**. |
Khaledgarbaya
force-pushed
the
umb-build
branch
2 times, most recently
from
4898159 to
b498be5
Compare
BREAKING CHANGE: We are droping any node version < 4.7
|
LGTM, the only concern I had i fixed on my own with the last commit. Works great with our discovery app :) Merge them! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is removing all legacy build setup and aim to have only one file for both targets node and browser to make integrating contentful.js with webpack for server side easier since we are droping support for old node versions. Also optimize lodash packaging.