-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added changes for seq_id #29
base: development
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vkalta, https://github.com/contentstack/contentstack-ios/blob/a2f87854f0c0a2232d653b39a52f5126a70e6ea1/ContentstackInternal/BSONObjectIdGenerator.m
seq_id generation using bason lib should be inside the persistence sdk not here. this is part of persistence
By the design currently the seq id, sync token and pagination is currently being updated inside the contentstack-ios project. This is why it was deemed to be added here and not in persistence package. Please let me know your thoughts on it. Thanks |
Contentstack/Stack.h
Outdated
|
||
@param completionBlock called synchronization is done. | ||
*/ | ||
- (void)syncSeqIdInit:(void (^)(SyncStack * BUILT_NULLABLE_P syncStack, NSError * BUILT_NULLABLE_P error))completionBlock; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The function should be named initSeqSync
or initialSequenceSync
.
Reasoning: Including "id" in the function name may cause confusion for developers as it doesn't serve any purpose in this context. This function doesn't require any input from the developer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
thanks @vkalta
@vkalta , approved but before merging the PR make sure to add below changes :
thank you ! |
This PR is a enhancement task with respect to the previous sync API implementation by replacing sync token with seq id.