Enrich exception based logs #51
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- passing exception object into logging pipeline instead of relying only on message / localized message being there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We noticed some log events in our system with
nullmessage. That seems to be coming from this SDK, there I noticed that you're simply logging the localized message. However since the message itself is a nullable property, and some exceptions might not provide it, would be great if we can enrich the logs with the exception itself to get a bit more clarity on what actually happened.Happy to get any feedback on this.
Actions taken
Note
Please note that this was simply a search & replace for places where there is a direct use of localized message in a log statement.