Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverted variant types fix and Update node version to 22 #262

Merged
merged 1 commit into from
Feb 6, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/npm-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ jobs:
publish-npm:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: '22.x'
registry-url: 'https://registry.npmjs.org'
Expand All @@ -22,8 +22,8 @@ jobs:
publish-git:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: '22.x'
registry-url: 'https://npm.pkg.github.com'
Expand Down
12 changes: 11 additions & 1 deletion lib/entity.js
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,17 @@ export const publishUnpublish = async (http, url, httpBody, headers, locale = nu
try {
const response = await http.post(url, httpBody, headers)
if (response.data) {
return response.data
const data = response.data || {}
if (headers) {
data.stackHeaders = headers;
}
if (http?.httpClientParams?.headers?.includeResHeaders === true) {
data.stackHeaders = {
...data.stackHeaders,
responseHeaders: response.headers,
};
}
return data
} else {
throw error(response)
}
Expand Down
82 changes: 41 additions & 41 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions test/typescript/variants.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { expect } from "chai"
import path from "path"
import { Stack } from "../../types/stack";
import { Variant, Variants } from "../../types/stack/VariantGroup/variants";
import { variantEntry, variantEntry2 } from "./mock/variants";
var tokenUID = ''
export function createVariant(stack: Stack) {
Expand Down
4 changes: 2 additions & 2 deletions types/stack/VariantGroup/variants/index.d.ts
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import { AnyProperty, SystemFields } from "../../../utility/fields";
import { Queryable, SystemFunction } from "../../../utility/operations";

export interface VariantGroupVariant extends SystemFields, SystemFunction<VariantGroupVariants> {
export interface Variant extends SystemFields, SystemFunction<Variants> {

}

export interface VariantGroupVariants extends Queryable<VariantGroupVariants, {variant: VariantData}> {
export interface Variants extends Queryable<Variants, {variant: VariantData}> {

}

Expand Down
6 changes: 3 additions & 3 deletions types/stack/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import { Taxonomy, Taxonomies } from "./taxonomy";
import { ManagementToken, ManagementTokens } from "./managementToken";
import { Variant, Variants } from "./variants";
import { VariantGroup, VariantGroups } from "./VariantGroup";
import { VariantGroupVariant, VariantGroupVariants } from "./VariantGroup/variants";
import { Variant, Variants } from "./VariantGroup/variants";

export interface StackConfig {
api_key:string
Expand Down Expand Up @@ -112,6 +112,6 @@ export interface Stack extends SystemFields {
variantGroup(): VariantGroups
variantGroup(uid: string): VariantGroup

variant(): VariantGroupVariants
variant(uid: string): VariantGroupVariant
variant(): Variants
variant(uid: string): Variant
}
Loading