Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added livepreview 2.0 and timeline support #95

Merged
merged 12 commits into from
Mar 14, 2025
Merged

Conversation

sunil-lakshman
Copy link
Contributor

No description provided.

@sunil-lakshman sunil-lakshman requested a review from Copilot March 12, 2025 13:32
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds Livepreview 2.0 and timeline support with improved handling of preview tokens and entry merging for live content. Key changes include:

  • Updates to live preview implementation in entry.py and query.py to support both management and preview tokens.
  • Modifications to DeepMergeMixin handling to ensure proper merging of entries.
  • Enhancements in tests and workflow files along with a version bump for the release.

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
contentstack/entry.py Updated live preview merging logic and added type-checking for entries.
contentstack/deep_merge_lp.py Adjusted merging logic to enforce lists of dictionaries.
contentstack/query.py Improved JSON response handling and updated lp_response extraction.
tests/test_live_preview.py Added new tests for Livepreview 2.0 and timeline support.
.github/workflows/jira.yml Updated Jira summary template.
CHANGELOG.md Added changelog for version v1.11.0.
contentstack/init.py Bumped the version to v1.11.0.
.github/workflows/sca-scan.yml Updated SCA scan workflow configuration.
tests/init.py Included TestLivePreviewConfig in the test suite.
contentstack/stack.py Refactored live preview query logic and initialization.
Comments suppressed due to low confidence (1)

contentstack/query.py:333

  • [nitpick] Consider replacing the print statement with a proper logging mechanism to handle JSON decode errors in production.
except json.JSONDecodeError as e:

@sunil-lakshman sunil-lakshman assigned cs-raj and unassigned cs-raj Mar 13, 2025
@sunil-lakshman sunil-lakshman requested a review from cs-raj March 13, 2025 06:25
@sunil-lakshman sunil-lakshman marked this pull request as ready for review March 14, 2025 08:38
@sunil-lakshman sunil-lakshman requested a review from a team as a code owner March 14, 2025 08:38
@sunil-lakshman sunil-lakshman merged commit 0fc46cc into development Mar 14, 2025
7 checks passed
@sunil-lakshman sunil-lakshman deleted the feat/dx-2213 branch March 14, 2025 08:43
sunil-lakshman added a commit that referenced this pull request Mar 14, 2025
Added livepreview 2.0 and timeline support (#95)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants