-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added livepreview 2.0 and timeline support #95
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds Livepreview 2.0 and timeline support with improved handling of preview tokens and entry merging for live content. Key changes include:
- Updates to live preview implementation in entry.py and query.py to support both management and preview tokens.
- Modifications to DeepMergeMixin handling to ensure proper merging of entries.
- Enhancements in tests and workflow files along with a version bump for the release.
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
contentstack/entry.py | Updated live preview merging logic and added type-checking for entries. |
contentstack/deep_merge_lp.py | Adjusted merging logic to enforce lists of dictionaries. |
contentstack/query.py | Improved JSON response handling and updated lp_response extraction. |
tests/test_live_preview.py | Added new tests for Livepreview 2.0 and timeline support. |
.github/workflows/jira.yml | Updated Jira summary template. |
CHANGELOG.md | Added changelog for version v1.11.0. |
contentstack/init.py | Bumped the version to v1.11.0. |
.github/workflows/sca-scan.yml | Updated SCA scan workflow configuration. |
tests/init.py | Included TestLivePreviewConfig in the test suite. |
contentstack/stack.py | Refactored live preview query logic and initialization. |
Comments suppressed due to low confidence (1)
contentstack/query.py:333
- [nitpick] Consider replacing the print statement with a proper logging mechanism to handle JSON decode errors in production.
except json.JSONDecodeError as e:
cs-raj
approved these changes
Mar 14, 2025
sunil-lakshman
added a commit
that referenced
this pull request
Mar 14, 2025
Added livepreview 2.0 and timeline support (#95)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.