Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for sync method not working correctly #141

Conversation

erikpost
Copy link

I couldn't get the sync method working, so I took a look and noticed two issues:

  • the URL used in the call is incorrect, it states '/sync' but it should be '/stacks/sync'
  • the way query parameters are passed to the getData call is incorrect, it provides the object holding the parameters instead of the parameters themselves

@erikpost erikpost requested a review from a team as a code owner February 24, 2025 09:00
@nadeem-cs
Copy link
Contributor

Thanks for the contribution! @erikpost
Can you please change the base branch of this PR from main to development. We'll take care of the rest and release this fix.
Thanks again.

@erikpost erikpost changed the base branch from main to development March 11, 2025 10:22
@erikpost
Copy link
Author

@nadeem-cs thanks for taking a look at this PR. I've updated the base branch to development as requested.

@nadeem-cs nadeem-cs merged commit d1b3e83 into contentstack:development Mar 11, 2025
3 of 5 checks passed
@erikpost erikpost deleted the bugfix/fix-incorrect-url-and-params branch March 17, 2025 10:06
@erikpost
Copy link
Author

@nadeem-cs when will this be released in a new version of the typescript SDK? would be great if we can remove the workaround from our own code and use an SDK version with the fix.

@nadeem-cs
Copy link
Contributor

@erikpost This will be released by next week. I will update here as soon as its released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants