Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] Add support for commitlint.config.yaml #2711

Closed
jcayzac opened this issue Aug 7, 2021 · 5 comments
Closed

[feature request] Add support for commitlint.config.yaml #2711

jcayzac opened this issue Aug 7, 2021 · 5 comments
Labels

Comments

@jcayzac
Copy link

jcayzac commented Aug 7, 2021

…not just commitlint.config.yml, because nice people use proper extensions (like .jpeg, not .jpg).

Expected Behavior

  • If a commitlint.config.yaml file exist, it is used by commitlint.
  • Priority is greater than commitlint.config.yml, but not greater than whatever currently has a higher priority than commitlint.config.yml.

Affected packages

cli

@jcayzac
Copy link
Author

jcayzac commented Aug 7, 2021

The nice people do joke aside, it's very annoying having files of the same format use different extensions, in a repo.

@escapedcat
Copy link
Member

Hey @jcayzac , happy for a PR here if you have time and motivation

@AdeAttwood
Copy link
Member

This can be done when #2698 is in. We are overriding the files list so we can add commitlint.config.yaml to the list of files cosmiconfig looks for

@jcayzac
Copy link
Author

jcayzac commented Aug 10, 2021

Nice, @AdeAttwood! I see .yaml is already included in that PR 🎉

@jcayzac
Copy link
Author

jcayzac commented Aug 21, 2021

Fixed by #2698

@jcayzac jcayzac closed this as completed Aug 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants