-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(load): add cosmiconfig typescript loader #2698
Conversation
@escapedcat request review |
Thank you @songhn233 for this PR and @polkovnikov-ph for the review and nitpicking ;) Let's wait for the others to review. |
The tests in load only include js-config-file, if ts-config-file tests are added then yaml and other format tests I think can be added as well. |
@escapedcat I tried to follow Conventional Comments. Seems to be very applicable for PRs in this repo :) (Of course I forgot to put a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good. I am with @escapedcat and can we get a test added for it.
Thanks for getting this one in 👍
Co-authored-by: Ade Attwood <[email protected]>
@escapedcat @AdeAttwood To avoid complex definitions for some properties I defined directly as |
The PR also fixes #2711 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is all good. TBH, I am not too worried about the types in this test. This test is fine to test that you can load a .ts
file in the config. We can sort out other tests for the types.
Do we need to update the docs for this? |
It's released, please have a look. Thanks |
Hey people, please have a look at this update PR: #3253 |
Description
Add ts format config support.
Reference to cosmiconfig loader document, add @endemolshinegroup/cosmiconfig-typescript-loader to load the ts config according to a higher priority than the js config.
Motivation and Context
#2652
Types of changes
Checklist: