Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix npm semver commits with type chore not being ignored #200

Merged
merged 1 commit into from
Dec 21, 2017
Merged

fix: fix npm semver commits with type chore not being ignored #200

merged 1 commit into from
Dec 21, 2017

Conversation

satazor
Copy link
Contributor

@satazor satazor commented Dec 20, 2017 •
edited
Loading

Added chore: vx.x.x to the list of ignores.

Description

Commitlint was failing to validate the commit produced by standard-version.

Motivation and Context

See #198

Usage examples

echo "chore: v1.0.0" | commitlint # passes
echo "chore: 1.0.0" | commitlint # passes
echo "chore(release): v1.0.0" | commitlint # passes
echo "chore(release): 1.0.0" | commitlint # passes

How Has This Been Tested?

Added the inputs above to the is-ignored tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@satazor satazor mentioned this pull request Dec 20, 2017
Closed
4 tasks
@marionebl marionebl merged commit cdbb085 into conventional-changelog:master Dec 21, 2017
@donifer
Copy link

donifer commented Dec 21, 2017

Would ❤️ a release with this.

@marionebl
Copy link
Contributor

@donifer Fix released via v5.2.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@satazor @donifer @marionebl