fix: solve dependency security issues #474
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a dependency security upgrade, complementary to #473.
Motivation and Context
I did a manual security audit, with
npm audit
, and found 2 issues. While one of them isn't included in any commitlint package, I think it's best to still upgrade because of the security level (critical). The other issue is a minor one, also related to old Lodash, through commitizen.root package
This one is related to
docsify-cli
using the insecureopen
library, this has been patched and refactored byopn
. This change is done here.@commitlint/prompt
There were 3 issues, 2 of them easily fixable by upgrading a package (commitizen). The first two are, like said before, lodash issues through the use of another dependency. I've checked the major patch of commitlint, the only big change is the dropped support for Node <6. Luckily, commitlint doesn't support lower than 6 either, so that should be compatible.
The other issue is related to Vorpal (and lodash again), but there is no fix (yet). Some discussion is taking place here.
Usage examplesHow Has This Been Tested?
It might be best to search for an automatic and continuous security check.
Types of changes
Checklist: