Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: port message to typescript #765

Merged
merged 2 commits into from
Sep 11, 2019
Merged

refactor: port message to typescript #765

merged 2 commits into from
Sep 11, 2019

Conversation

byCedric
Copy link
Member

Description

Part of #659

Motivation and Context

Usage examples

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@marionebl marionebl mentioned this pull request Jul 27, 2019
Closed
18 tasks
@byCedric byCedric force-pushed the refactor/message-to-ts branch from 9adc34e to 2e9d32f Compare July 27, 2019 11:30
marionebl
marionebl reviewed Jul 29, 2019
View reviewed changes
Copy link
Contributor

@marionebl marionebl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor type-related comments, thanks again!

@byCedric byCedric force-pushed the refactor/message-to-ts branch from bb0b18b to 630f117 Compare September 11, 2019 10:48
@byCedric
Copy link
Member Author

@marionebl Is this PR good to merge? I think it's done 😄

@byCedric byCedric force-pushed the refactor/message-to-ts branch from 630f117 to 069013f Compare September 11, 2019 14:54
@byCedric byCedric merged commit a9f98e0 into master Sep 11, 2019
@byCedric byCedric deleted the refactor/message-to-ts branch September 11, 2019 16:05
@byCedric
Copy link
Member Author

Chatted with @marionebl, PR was ready! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marionebl marionebl marionebl left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@byCedric @marionebl