Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add improvement to allowed list. #832

Merged
merged 1 commit into from
Oct 20, 2019

Conversation

OmgImAlexis
Copy link
Contributor

@byCedric
Copy link
Member

byCedric commented Oct 20, 2019

Thanks, I'll merge this one! Seems that it's coming directly from the spec, so we should include it. We currently have an issue with conventional changelog parser presets, so I'll create a new version after that one is resolved.

Please be aware that we are upgrading our default configs to match the specification a bit more. These changes probably include the removal of specific types, as mentioned here, also see issue #658

@AndersDJohnson
Copy link

@OmgImAlexis @byCedric It looks like they removed improvement as recommended. It was in their 1.0.0-beta.4 release, but removed in 1.0.0.

I'm proposing we consider removing it in commitizen/conventional-commit-types#16, so I would appreciate if you could share thoughts there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

"improvement" offered as an option but not in enum
3 participants