Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement XEP-0333 displayed and acknowledged chat markers #2028

Closed
deleolajide opened this issue May 14, 2020 · 6 comments
Closed

Implement XEP-0333 displayed and acknowledged chat markers #2028

deleolajide opened this issue May 14, 2020 · 6 comments
Labels

Comments

@deleolajide
Copy link
Member

deleolajide commented May 14, 2020

Is your feature request related to a problem? Please describe.
Currently, only the received chat marker is implemented in Converse. However, Prosody is able to handle displayed and acknowledged chat markers in order to send accurate room activity notifications back to Converse

Describe the solution you'd like
Converse is tracking the total unread messages and first unread message displayed in a chatbox as well as user gestures that reset the counter. When the counter gets reset, mark the last message as acknowledged. All new messages should be marked as displayed.

deleolajide added a commit to deleolajide/converse.js that referenced this issue May 14, 2020
@jcbrand
Copy link
Member

jcbrand commented Jun 3, 2020

@deleolajide Can this be closed now?

@deleolajide
Copy link
Member Author

Yes please

@mightymop
Copy link

I got a question:
How are theese markers are displayed in the chatbox?
I only get one green marker for message reception. Are there any addional markers if the opponent have read the message? Or is the color changing? I can see that converse sends the displaymessage, so that conversations show me the message that the converseuser have read the message, but the other way around may be buggy?

@jcbrand
Copy link
Member

jcbrand commented Nov 24, 2020

@mightymop: AFAIK Converse doesn't show anything related to these markers in the UI. It only supports these markers by notifying your chat partner that a message has been received/displayed etc.

@mightymop
Copy link

@mightymop: AFAIK Converse doesn't show anything related to these markers in the UI. It only supports these markers by notifying your chat partner that a message has been received/displayed etc.

@jcbrand: thanks for your answer...

so maybe it would be a good improvement to add this to the ui? maybe simple colorize the existing check symbol to blue with css or add a second one?

@jcbrand
Copy link
Member

jcbrand commented Nov 25, 2020

@mightymop: You're welcome to create a new feature request for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants