Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(skeleton): skeletonization for text #1606

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

fulcanellee
Copy link
Collaborator

@fulcanellee fulcanellee commented Mar 7, 2025

DS-4120

  • Перенос хука useSkeleton из Typography в Skeleton
  • Обновление демки
  • Исправление незаконченного теста
  • Перенос Skeleton stories на tsx

Copy link

changeset-bot bot commented Mar 7, 2025

🦋 Changeset detected

Latest commit: ffc53c0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 39 packages
Name Type
@alfalab/core-components-skeleton Minor
@alfalab/core-components-typography Minor
@alfalab/core-components-calendar-with-skeleton Patch
@alfalab/core-components-select Patch
@alfalab/core-components-tabs Patch
@alfalab/core-components-accordion Patch
@alfalab/core-components-calendar Patch
@alfalab/core-components-chart Patch
@alfalab/core-components-circular-progress-bar Patch
@alfalab/core-components-comment Patch
@alfalab/core-components-confirmation Patch
@alfalab/core-components-file-upload-item Patch
@alfalab/core-components-gallery Patch
@alfalab/core-components-list-header Patch
@alfalab/core-components-list Patch
@alfalab/core-components-markdown Patch
@alfalab/core-components-navigation-bar-private Patch
@alfalab/core-components-navigation-bar Patch
@alfalab/core-components-product-cover Patch
@alfalab/core-components-pure-cell Patch
@alfalab/core-components-stepped-progress-bar Patch
@alfalab/core-components-tab-bar Patch
@alfalab/core-components-universal-modal Patch
@alfalab/core-components-custom-picker-button Patch
@alfalab/core-components-input-autocomplete Patch
@alfalab/core-components-international-phone-input Patch
@alfalab/core-components-intl-phone-input Patch
@alfalab/core-components-picker-button Patch
@alfalab/core-components-select-with-tags Patch
@alfalab/core-components-table Patch
@alfalab/core-components-calendar-input Patch
@alfalab/core-components-calendar-range Patch
@alfalab/core-components-date-range-input Patch
@alfalab/core-components-date-time-input Patch
@alfalab/core-components-bottom-sheet Patch
@alfalab/core-components-modal Patch
@alfalab/core-components-popup-sheet Patch
@alfalab/core-components-side-panel Patch
@alfalab/core-components-tooltip Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@fulcanellee fulcanellee marked this pull request as draft March 7, 2025 11:51
@fulcanellee fulcanellee changed the title Feat/ds 4120 feat(skeleton): skeletonization for text Mar 7, 2025
@coveralls
Copy link

coveralls commented Mar 7, 2025

Pull Request Test Coverage Report for Build 13723431736

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.211%

Totals Coverage Status
Change from base Build 13718019813: 0.0%
Covered Lines: 11266
Relevant Lines: 12500

💛 - Coveralls

@core-ds-bot
Copy link
Collaborator

core-ds-bot commented Mar 7, 2025

Собрана новая демка.

@fulcanellee fulcanellee marked this pull request as ready for review March 7, 2025 15:06
@fulcanellee fulcanellee requested a review from Oladii March 7, 2025 15:09
@@ -1 +0,0 @@
export * from './use-skeleton';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

для обратной совместимости наверное нужно сохранить экспорт

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а он не выглядывал наружу, использовался только внутри типографики, поэтому должно быть ок

@fulcanellee fulcanellee requested a review from hextion March 17, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants