fix(navigation-bar): добавить проброс пропсов для Closer [DS-9232] #1613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dHIM24
requested review from
reme3d2y,
fulcanellee,
SiebenSieben and
hextion
as code owners
🦋 Changeset detectedLatest commit: 04c1818 The changes in this PR will be included in the next version bump. This PR includes changesets to release 23 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Pull Request Test Coverage Report for Build 14055438296Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
Собрана новая демка. |
hextion
requested changes
Mar 13, 2025
packages/navigation-bar-private/src/components/closer/Component.tsx
Outdated
Show resolved
Hide resolved
hextion
requested changes
Mar 24, 2025
| @@ -226,6 +232,7 @@ export const PopupSheet = forwardRef<HTMLDivElement, PopupSheetProps>( | |||
| className={styles.closer} | |||
There was a problem hiding this comment.
className={cn(styles.closer,closerProps?.className)}
fulcanellee
requested changes
Mar 24, 2025
.changeset/cuddly-clocks-cry.md
Outdated
| '@alfalab/core-components-popup-sheet': minor | ||
| --- | ||
|
|
||
| добавлена возможность передовать дополнительные props в компонент Closer |
There was a problem hiding this comment.
Suggested change
| добавлена возможность передовать дополнительные props в компонент Closer | |
| Добавлена возможность передавать дополнительные props в компонент Closer |
There was a problem hiding this comment.
и чуть подробнее описать
hextion
requested changes
Mar 25, 2025
| /** | ||
| * Дополнительные пропсы для компонента Closer. | ||
| */ | ||
| closerProps?: Omit<CloserProps, 'view' | 'onClick'>; |
There was a problem hiding this comment.
Omit<CloserProps, 'view' | 'onClick'> -> Omit<CloserProps, 'view' | 'onClose'>
из самого типа CloserProps исключить onClick
fulcanellee
approved these changes
Mar 25, 2025
hextion
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Обновил снэпшот тесты, написал тест на проброс инлайнового стиля для Closer, установил кастомное значение z-index: 2. Предлагаю обсудить, точно ли необходима правка, а если необходима, то точно ли стоит пробрасывать пропс под z-index?
Чек лист
Если есть визуальные изменения