Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(typography): added Alfa Interface Sans font support #1617

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat(typography): added Alfa Interface Sans font support #1617

wants to merge 2 commits into from

Conversation

hextion
Copy link
Collaborator

@hextion hextion commented Mar 14, 2025 •
edited by fulcanellee
Loading

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 14, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 030ac9a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coveralls
Copy link

coveralls commented Mar 14, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 14019491921

Details

  • 12 of 14 (85.71%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 82.197%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/typography/src/title/component.tsx 4 6 66.67%
Totals Coverage Status
Change from base Build 13904287373: -0.01%
Covered Lines: 11274
Relevant Lines: 12510
💛 - Coveralls

@core-ds-bot
Copy link
Collaborator

core-ds-bot commented Mar 14, 2025 •
edited
Loading

Собрана новая демка.

@hextion hextion requested a review from dHIM24 as a code owner March 17, 2025 16:15
SiebenSieben
SiebenSieben reviewed Mar 18, 2025
View reviewed changes
packages/typography/src/title/index.tsx
import commonStyles from './common.module.css';
import styles from './index.module.css';

const allStyles =
process.env.NODE_ENV === 'test'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Это что-то временное?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

это исключительно для тестов, чтобы работал пакет identity-obj-proxy

@hextion hextion force-pushed the alfasans branch 2 times, most recently from 053b85b to c95854b Compare March 18, 2025 10:36
@hextion hextion force-pushed the alfasans branch 2 times, most recently from 1aa2b0e to b69d460 Compare March 23, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SiebenSieben SiebenSieben SiebenSieben approved these changes

@reme3d2y reme3d2y Awaiting requested review from reme3d2y

@fulcanellee fulcanellee Awaiting requested review from fulcanellee fulcanellee is a code owner

@dHIM24 dHIM24 Awaiting requested review from dHIM24 dHIM24 is a code owner

At least 3 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hextion @coveralls @core-ds-bot @SiebenSieben