fix(abci): add unwrapper to handle join error #23712
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmsqe
commented
Feb 15, 2025
12 tasks
alpe
reviewed
Mar 10, 2025
baseapp/baseapp_test.go
Outdated
| @@ -4,6 +4,7 @@ import ( | |||
| "bytes" | |||
| "context" | |||
| "crypto/sha256" | |||
| "errors" | |||
There was a problem hiding this comment.
the same errors package as in baseapp should be used
errors/abci.go
Outdated
| @@ -59,6 +59,16 @@ func abciCode(err error) uint32 { | |||
| } | |||
|
|
|||
| for { | |||
| if c, ok := err.(interface{ Unwrap() []error }); ok { | |||
There was a problem hiding this comment.
would be nice to have this interface extracted with some meaningful name
| errs := c.Unwrap() | ||
| for _, e := range errs { | ||
| if e != nil { | ||
| err = e |
There was a problem hiding this comment.
I am not sure if "first error" wins is correct. You could also have first coder error win. or last... it would be good to understand the scenario better. I have commented on the issue.
Skipping any nil errors does make sense though. This could be achieved by using Go stdlib errors.Join in baseapp as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #23709
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...