feat: add in distribution to x/protocolpool
#23972
Conversation
|
@aljo242 your pull request is missing a changelog! |
| ModuleName: authtypes.ModuleName, | ||
| KvStoreKey: "acc", | ||
| }, | ||
| ModuleConfig = []*appv1alpha1.ModuleConfig{ |
There was a problem hiding this comment.
factored this out so that we can do some modifications to it in the network tests
| network *network.Network | ||
| } | ||
|
|
||
| func NewGRPCQueryTestSuite(protocolPoolEnabled bool) *GRPCQueryTestSuite { |
There was a problem hiding this comment.
we can now create this test suite with the x/protocolpool enabled or not
| @@ -7,6 +7,11 @@ import ( | |||
| "net/http" | |||
| ) | |||
|
|
|||
| type ErrorResponse struct { | |||
There was a problem hiding this comment.
defining a common struct that is returned when your query fails. tests can just decode to this
| "github.com/cosmos/cosmos-sdk/x/distribution/types" | ||
| ) | ||
|
|
||
| const truncationBlockInterval = 1000 |
There was a problem hiding this comment.
This is what was defined before (not as a constant). I am not sure why this number was chosen - I'm assuming arbitrary
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if err := k.AllocateTokens(ctx, previousTotalPower, ctx.VoteInfos()); err != nil { | ||
| return err | ||
| } | ||
| if err := k.BeginBlocker(ctx); err != nil { |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
| // ref https://github.com/cosmos/cosmos-sdk/issues/3095 | ||
| height := ctx.BlockHeight() | ||
| if height > 1 { | ||
| if err := k.AllocateTokens(ctx, previousTotalPower, ctx.VoteInfos()); err != nil { |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
|
|
||
| // every 1000 blocks send whole coins from community pool to x/protocolpool if enabled | ||
| if height%truncationBlockInterval == 0 && k.protocolPoolEnabled { | ||
| if err := k.sendCommunityPoolToProtocolPool(ctx); err != nil { |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
|
|
||
| // record the proposer for when we pay out on the next block | ||
| consAddr := sdk.ConsAddress(ctx.BlockHeader().ProposerAddress) | ||
| return k.SetPreviousProposerConsAddr(ctx, consAddr) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
sendCommunityPoolToProtocolPoolfunction call in beginblocker every 1000 blocksx/distributionwhenx/protocolpoolis enabled