Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Refactor GitHub workflows and add code coverage job #120

Merged
merged 10 commits into from
Nov 28, 2022

Conversation

romac
Copy link
Member

@romac romac commented Nov 28, 2022

No description provided.

@romac romac changed the title Split GitHub Actions definitions per language chore: Split GitHub Actions definitions per language Nov 28, 2022
@romac romac changed the title chore: Split GitHub Actions definitions per language ci: Split GitHub Actions definitions per language Nov 28, 2022
@romac
Copy link
Member Author

romac commented Nov 28, 2022

Not sure why each CI workflow (go, rust, ts) is marked as "Expected — Waiting for status to be reported" even though the jobs have all finished running.

@cosmos cosmos deleted a comment from codecov-commenter Nov 28, 2022
@romac romac force-pushed the romac/refactor-gh-actions branch from 05190e0 to dfb4d85 Compare November 28, 2022 21:09
@romac romac changed the title ci: Split GitHub Actions definitions per language ci: Refactor GitHub workflows and add code coverage job Nov 28, 2022
@cosmos cosmos deleted a comment from codecov-commenter Nov 28, 2022
@romac
Copy link
Member Author

romac commented Nov 28, 2022

Not sure why each CI workflow (go, rust, ts) is marked as "Expected — Waiting for status to be reported" even though the jobs have all finished running.

Fixed by updating the required status checks in the settings.

@romac romac requested review from tac0turtle and hu55a1n1 November 28, 2022 22:15
@romac romac marked this pull request as ready for review November 28, 2022 22:15
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome clean up

@tac0turtle tac0turtle merged commit 4232e6c into master Nov 28, 2022
@tac0turtle tac0turtle deleted the romac/refactor-gh-actions branch November 28, 2022 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants