Replace "of [...] storage duration" with "with [...] storage duration" #7357
+7
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No objections from me for the library parts. |
|
Could you please put quotation marks into the commit messages to distinguish the phrase in question from the message itself? |
jensmaurer
approved these changes
Dec 17, 2024
jensmaurer
added
the
changes requested
|
@Eisenwave Ping? |
…s] Say "with thread storage duration"
Eisenwave
force-pushed
the
with-storage-duration
branch
from
42b400c to
5eb44f4
Compare
|
@tkoeppe Pong. |
Eisenwave
force-pushed
the
with-storage-duration
branch
from
5eb44f4 to
91eeab6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have two different prepositions in relation to "storage duration"
For the purpose of uniformity and grepability, we should settle on one convention. To say "with [...] storage duration" is overwhelmingly more common, so it should be preferred.