Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P3378R2 constexpr exception types #7701

Merged
merged 1 commit into from
Mar 15, 2025
Merged

P3378R2 constexpr exception types #7701

merged 1 commit into from
Mar 15, 2025

Conversation

Eisenwave
Copy link
Contributor

@Eisenwave
Copy link
Contributor Author

@jwakely two questions:

  1. std::bad_expected_access (both the primary template and the <void> specialization) are missing \impldef on ::what(), unlike std::bad_optional_access. Should that be fixed up here?
  2. Did I give the correct value to cpp_lib_constexpr_exceptions?

@Eisenwave Eisenwave force-pushed the motions-2025-02-lwg-7 branch from 22b0d66 to d216d6b Compare February 19, 2025 11:22
@jwakely
Copy link
Member

jwakely commented Feb 19, 2025

Yes and yes, thanks

@tkoeppe tkoeppe force-pushed the motions-2025-02-lwg-7 branch from bdaf98c to 7b9506a Compare March 15, 2025 13:13
@tkoeppe tkoeppe merged commit 1dd4db8 into cplusplus:main Mar 15, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burblebee burblebee burblebee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[2025-02 LWG Motion 7] P3378R2 constexpr exception types P3378 R2 constexpr exception types
4 participants
@Eisenwave @jwakely @burblebee @tkoeppe