Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2025-02 CWG Motion 9] P1967R14 #embed #7704

Merged
merged 3 commits into from
Mar 15, 2025
Merged

Conversation

AlisdairM
Copy link
Contributor

@AlisdairM AlisdairM commented Feb 19, 2025

Fixes #7659.
Also fixes cplusplus/papers#700.

Redistributed grammar around the preamble to better maintain a locality and flow. More redistrubution expected in a follow-up commit.

Minor grammar tweak: "other than a" -> "except:"
following the model of such specifications in
basic-s-char and elsewhere.

Attempted to describe all implementation-defined
topics for the index, but will need review.

@AlisdairM AlisdairM changed the title [2025-02 CWG Motion 9] #embed [2025-02 CWG Motion 9] #embed Feb 19, 2025
@AlisdairM AlisdairM force-pushed the p1967_embed branch 3 times, most recently from d2e8b8f to 963aadc Compare February 19, 2025 17:21
@AlisdairM AlisdairM changed the title [2025-02 CWG Motion 9] #embed [2025-02 CWG Motion 9] P1967R14 #embed Feb 19, 2025
@AlisdairM AlisdairM force-pushed the p1967_embed branch 4 times, most recently from d9b7453 to aece602 Compare February 20, 2025 19:30
@hubert-reinterpretcast
Copy link
Contributor

Can we add has-embed-expression‌s to this list despite it being a change missing in the paper?

After all replacements due to macro expansion and
evaluations of
\grammarterm{defined-macro-expression}s,
\grammarterm{has-include-expression}s, and
\grammarterm{has-attribute-expression}s
have been performed,

Or do we need @jensmaurer to create a new Core Issue?

@jensmaurer
Copy link
Member

I think the change suggested by @hubert-reinterpretcast is editorial; this is part of the necessary evaluation semantics. Please add in a separate commit with the "[label] title" description style.

@AlisdairM AlisdairM force-pushed the p1967_embed branch 2 times, most recently from c2db747 to fb206cd Compare February 24, 2025 15:30
@AlisdairM
Copy link
Contributor Author

This PR is still showing as "changes requested". I believe I have addressed all issues, could someone point out where I have missed, or remove the status?

@tkoeppe tkoeppe force-pushed the p1967_embed branch 5 times, most recently from 86c6128 to af326e1 Compare March 15, 2025 11:00
Editorial notes:
* Redistributed grammar around the preamble to better
  maintain a locality and flow.
* Minor grammar tweak: "other than a" -> "except:".
Following the style of the equivalent paragraph
introduced with the `embed` wording.
@tkoeppe tkoeppe merged commit 7578125 into cplusplus:main Mar 15, 2025
1 check passed
@AlisdairM AlisdairM deleted the p1967_embed branch March 15, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants