Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P2976R1 Freestanding Library: algorithm, numeric, and random #7706

Merged
merged 1 commit into from
Mar 15, 2025

Conversation

Eisenwave
Copy link
Contributor

Copy link

@ben-craig ben-craig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not an editor, but here's my review of the paper vs. the latex.

Comment on lines +193 to +198
void uninitialized_default_construct(ExecutionPolicy&& exec, // freestanding-deleted,
NoThrowForwardIterator first, // see \ref{algorithms.parallel.overloads}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this comment is aligned with the other // freestandings. Same for others in this file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine, do you have anything specific in mind?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections to the status quo.

@tkoeppe tkoeppe force-pushed the motions-2025-02-lwg-10 branch 3 times, most recently from 7beb045 to bdced58 Compare March 15, 2025 13:54
@tkoeppe tkoeppe force-pushed the motions-2025-02-lwg-10 branch from bdced58 to 9f05d3f Compare March 15, 2025 14:23
@tkoeppe tkoeppe merged commit 53fb302 into cplusplus:main Mar 15, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants