Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[intro.defs] access should contain a reference to the definition of a scalar type #7743

Conversation

LucyEngine
Copy link
Contributor

@LucyEngine LucyEngine commented Mar 17, 2025

Fixes #7741

@tkoeppe
Copy link
Contributor

tkoeppe commented Mar 17, 2025

There's no need to keep making new pull requests for the same thing! Just push or force-push into the existing PR branch.

@LucyEngine
Copy link
Contributor Author

There's no need to keep making new pull requests for the same thing! Just push or force-push into the existing PR branch.

I tried, but at the moment of doing the PR it didn't let me open it (there was only the option of viewing the last PR)

@tkoeppe
Copy link
Contributor

tkoeppe commented Mar 17, 2025

You can post a message to that regard and we can reopen the pull request, I think.

@tkoeppe
Copy link
Contributor

tkoeppe commented Mar 17, 2025

Regarding the commit message: just say what you're changing; you don't need to explain the entire motivation when it's obvious, but certainly the motivation shouldn't be the first line. The first line shoud say what's changing.

@LucyEngine
Copy link
Contributor Author

Okay, it's my first time submitting a PR btw, sorry, mistakes were committed, but i'll do better from now on

@tkoeppe
Copy link
Contributor

tkoeppe commented Mar 17, 2025

No worries, there's a first time for everything!

@LucyEngine
Copy link
Contributor Author

So uh, what's the error about? Apparently there're a bunch of undefined references or something... Looks similar to the error i got from mactex 2025

@AlisdairM
Copy link
Contributor

Those missing references are surprising to me. Have you successfully built a copy of the standard from main?

@tkoeppe
Copy link
Contributor

tkoeppe commented Mar 17, 2025

The reference is misspelled. Delete the trailing #9.

@LucyEngine
Copy link
Contributor Author

LucyEngine commented Mar 18, 2025

The reference is misspelled. Delete the trailing #9.

Done, sorry, i thought there was a direct reference to the different sub-sections/paragraphs of these sections.

Co-authored-by: A. Jiang <[email protected]>
@jensmaurer
Copy link
Member

@LucyEngine , if you wish for your real name to appear in the git commit history, you need to adjust your github profile settings accordingly.

@LucyEngine
Copy link
Contributor Author

@LucyEngine , if you wish for your real name to appear in the git commit history, you need to adjust your github profile settings accordingly.

Ah, don't worry, the github username is fine

@jensmaurer jensmaurer merged commit 2a71697 into cplusplus:main Mar 18, 2025
1 check passed
@LucyEngine LucyEngine deleted the reference-scalar-types-in-access-definition branch March 19, 2025 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[intro.defs] access should contain a reference to the definition of an scalar type
5 participants