Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Odd msvc warning now about /W4 #251

Closed
vinniefalco opened this issue Jun 5, 2023 · 3 comments
Closed

Odd msvc warning now about /W4 #251

vinniefalco opened this issue Jun 5, 2023 · 3 comments
Assignees

Comments

@vinniefalco
Copy link
Member

>------ Build started: Project: CMakeLists, Configuration: Debug ------
  MSBuild version 17.5.1+f6fdcf537 for .NET Framework
  
    Checking File Globs
    Checking Build System
    Building Custom Rule C:/Users/Vinnie/src/mrdox/CMakeLists.txt
C:\Users\Vinnie\src\mrdox\build\cmake-msvc\DebugWithRel\cl : command line warning D9025: overriding '/W4' with '/w' 
@sdkrystian
Copy link
Member

include(HandleLLVMOptions) is what adds all the non-target specific compile flags (including /W4), which conflicts with the /w flag used for duktape.

@alandefreitas
Copy link
Collaborator

non-target specific compile flags

Oh... I hate these. /w is private even.

I think there's a way to use LLVM with this module but I don't remember how.

I guess we can fix this simply by finding LLVM last though.

@alandefreitas
Copy link
Collaborator

I tried importing LLVM after all other dependencies but the error is still there.

https://github.com/alandefreitas/mrdox/actions/runs/5197321858/jobs/9372010104#step:6:1295

I think the only solution here is to find another way to consume LLVM without these scripts that define global requirements.

alandefreitas added a commit to alandefreitas/mrdocs that referenced this issue Jun 7, 2023
LLVM unfortunately defines global compile flags that are inherited by all other targets in the project, including fetched dependencies. Warning flags, with are functionally unnecessary, can cause conflicts with other targets.

fix cppalliance#251
alandefreitas added a commit to alandefreitas/mrdocs that referenced this issue Jun 7, 2023
LLVM unfortunately defines global compile flags that are inherited by all other targets in the project, including fetched dependencies. Warning flags, with are functionally unnecessary, can cause conflicts with other targets.

fix cppalliance#251
sdkrystian pushed a commit to sdkrystian/mrdocs that referenced this issue Jun 16, 2023
LLVM unfortunately defines global compile flags that are inherited by all other targets in the project, including fetched dependencies. Warning flags, with are functionally unnecessary, can cause conflicts with other targets.

fix cppalliance#251
sdkrystian pushed a commit to sdkrystian/mrdocs that referenced this issue Jun 16, 2023
LLVM unfortunately defines global compile flags that are inherited by all other targets in the project, including fetched dependencies. Warning flags, with are functionally unnecessary, can cause conflicts with other targets.

fix cppalliance#251
alandefreitas added a commit to alandefreitas/mrdocs that referenced this issue Jun 20, 2023
LLVM unfortunately defines global compile flags that are inherited by all other targets in the project, including fetched dependencies. Warning flags, with are functionally unnecessary, can cause conflicts with other targets.

fix cppalliance#251
alandefreitas added a commit to alandefreitas/mrdocs that referenced this issue Jul 3, 2023
LLVM unfortunately defines global compile flags that are inherited by all other targets in the project, including fetched dependencies. Warning flags, with are functionally unnecessary, can cause conflicts with other targets.

fix cppalliance#251
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants