Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds a progress bar when circleselector is running #13

Merged
merged 6 commits into from
Nov 15, 2021
Merged

Adds a progress bar when circleselector is running #13

merged 6 commits into from
Nov 15, 2021
+32 −22

Conversation

reubenlindroos
Copy link
Collaborator

@reubenlindroos reubenlindroos commented Nov 3, 2021 •
edited
Loading

Also improves speed of the circleselector module by ~50%

Todo:

  • add tqdm to requirements.txt
  • np.diffs for find_path_length
  • atomic lock for incrementing the progress bar?

Sorry, something went wrong.

cr333
cr333 requested changes Nov 11, 2021
View reviewed changes
Copy link
Owner

@cr333 cr333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some cleanup is needed, but looking good otherwise 👍

@reubenlindroos reubenlindroos merged commit 508aa0b into main Nov 15, 2021
@reubenlindroos reubenlindroos deleted the circleselector-update branch November 15, 2021 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cr333 cr333

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@reubenlindroos @cr333