Fix drop_first method name for typing
#37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bf1a74d added suport for "drop_front" but internally named this method "drop_first". Since the test code uses "drop_first", and to prevent creating a backwards incompatible change, I have chosen to fix the type defintion rather than the internal method name, even though the origin commit used "drop_front" in the commit message.
|
Sounds good, we can at some point add an alias for the "right" name if need be. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bf1a74d added support for "drop_front" but internally named this method "drop_first".
Since the test code uses "drop_first", and to prevent creating a backwards incompatible change, I have chosen to fix the type definition rather than the internal method name, even though the original commit used "drop_front" in the commit message.