rhel support & ldap support

[DubbleClick]

I wasn't quite able to get ldap to work when building static-php-cli, but it's trivial on rhel/debian - just run

dnf install sqlite-devel openldap-devel
ln -s /usr/lib64/libldap.so /usr/lib/libldap.so && ln -s /usr/lib64/liblber.so /usr/lib/liblber.so
php-src-folder/configure --with-ldap=/usr

openldap-devel is called libldap2-dev on debian.

Edit: If you want to add a pipeline for rhel (not required imo) this is the full install script to get things running on rhel.
epel-release is required for most of the things to install, remi only for php 8.2. The default still downloads 8.0 by default, which doesn't work.

dnf install epel-release
dnf install -y https://dl.fedoraproject.org/pub/epel/epel-release-latest-9.noarch.rpm 
dnf install -y https://rpms.remirepo.net/enterprise/remi-release-9.rpm  
dnf module enable php:remi-8.2
dnf install tar git zip php php-sodium php-zip libsodium wget

cd /opt
git clone https://github.com/crazywhalecc/static-php-cli.git
wget https://musl.libc.org/releases/musl-1.2.4.tar.gz

tar -xzf musl-1.2.4.tar.gz
cd musl-1.2.4.tar.gz
./configure
make -j
make install
cd ../static-php-cli

dnf install bison flex bzip2 cmake patch
dnf install sqlite-devel openldap-devel
ln -s /usr/lib64/libldap.so /usr/lib/libldap.so && ln -s /usr/lib64/liblber.so /usr/lib/liblber.so

php-src-dir/configure --with-ldap=/usr

[jingjingxyk]

please with openldap static link library

build reference : https://github.com/jingjingxyk/swoole-cli/blob/new_dev/sapi/src/builder/library/openldap.php#L37

[crazywhalecc]

@DubbleClick Only libraries supported by static compilation can be added to static-php-cli. Currently, all packages installed by dnf are dynamically linked. So the core point is to write a method that can statically compile the openldap library.

[DubbleClick]

ready for review now, I think everything is working as it should

[DubbleClick]

For what it's worth, I've only required perl for RHEL distros now, but I think it should be a requirement for debian and alpine too. Doesn't seem like a good idea to rely on perl being installed by default.

[DubbleClick]

Cleaned up a few last things: enabled ldap for MacOS and moved the source to /php-src/ext/ldap.

[DubbleClick]

When compiling ldap with openssl support, the zlib extension needs to be enabled. If compiled without openssl support, zlib is not required. I didn't put zlib in ext-requires because of that and instead check for openssl lib & zlib extension before enabling --with-tls

[crazywhalecc]

For what it's worth, I've only required perl for RHEL distros now, but I think it should be a requirement for debian and alpine too. Doesn't seem like a good idea to rely on perl being installed by default.

Debian and Alpine has installed perl I guess (with current dependencies).

[crazywhalecc]

When compiling ldap with openssl support, the zlib extension needs to be enabled. If compiled without openssl support, zlib is not required. I didn't put zlib in ext-requires because of that and instead check for openssl lib & zlib extension before enabling --with-tls

My understanding: If you want ldap to support openssl, then it must include the zlib library. This can actually be solved like this: openssl extension adds ext-depends: zlib.

[DubbleClick]

Correct, but Openssl extension itself doesn't require zlib extension.

Ldap without tls needs nothing.
Ldap with tls needs openssl lib, zlib lib, zlib ext.
Openssl needs zlib lib.

[crazywhalecc]

Although the openssl extension does not require the zlib extension, according to the current extension inclusion logic, the zlib extension should be enabled when you include the zlib library, so this is reasonable.

[crazywhalecc]

Documentation Task

• extension.md
• CliGenerator.vue
• doctor for RHEL part

[DubbleClick]

The doctor command doesn't have notes about specific operating systems. Rhel would just count under linux, I think we have nothing to document there.
I've added the ldap extension to extensions.md (en an zh)

[crazywhalecc]

I tested on my local AlmaLinux VM, and I found that the compilation part worked perfectly, but the doctor part needed some changes: The path was not added correctly when compiling musl. We need to manually write ~/.bashrc or execute export once in the current terminal.