Fix tool name method to strip unsupported characters for OpenAI

[stevegeek]

Updates the name method in the Tool class to strip unsupported characters and replace them with '-' characters as OpenAI only supports tool names with /a-zA-Z0-9_-/+

[crmne]

This is a great first contribution! Small, focused, and tested - exactly the kind of PR that's easy to review and merge.

One small suggestion: instead of simply replacing invalid characters with hyphens, could we implement something that converts to a more semantically appropriate alternative? For example, SampleTòol would become sample_tool rather than sample_t-ol.

If there's no straightforward way to implement this, I'm inclined to accept the PR as-is since it fixes a real issue. Let me know your thoughts!

[stevegeek]

Ok will find some time soon to update to transliterate appropriately!

[crmne]

Pretty good overall. Just waiting on this .unicode_normalize(:nfkd).encode('ASCII', replace: '') and the other few comments to be addressed.

[crmne]

Looks like overcommit was not installed and therefore rubocop complained. Here's how to fix both issues:

overcommit --install
rubocop -A

[stevegeek]

doh sorry

[crmne]

no problem! :)

[crmne]

Investigating: https://securitylab.github.com/resources/github-actions-preventing-pwn-requests/

[stevegeek]

@crmne ok sure, if I can be of any help, let me know.

[crmne]

I was checking into the permissions for running tests safely, and I think we need to take a different approach.

Instead of trying to dance around GitHub Actions security model with labels and pull_request_target, let's do this right by implementing VCR to record our API interactions. This will let us run the test suite against PRs without exposing our real API keys, and as a bonus make the tests faster and more reliable.

I'm going to work on adding VCR support before proceeding with this PR. Doing proper testing without compromising security is worth the small delay.

Will get back to you soon with the updated approach.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.75%. Comparing base (8fce3ac) to head (582ac34).
Report is 4 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
+ Coverage   92.67%   92.75%   +0.07%     
==========================================
  Files          54       55       +1     
  Lines        1665     1683      +18     
  Branches      284      284              
==========================================
+ Hits         1543     1561      +18     
  Misses        122      122              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.