Add o3-mini support & expose "temperature" #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code was mentioning `o3-mini` but somehow this model wasn't part of the `models.json` configuration file. I assume it could because it doesn't support the `temperature` parameter, so things had to get slightly adjusted.
redox
commented
Mar 17, 2025
| model_id = model || RubyLLM.config.default_model | ||
| self.model = model_id | ||
| @temperature = @model.metadata['family'] == 'o1' ? 1 : 0.7 |
There was a problem hiding this comment.
I don't think this was ever working, the family is one level above the metadata.
redox
commented
Mar 17, 2025
| "object": "model", | ||
| "owned_by": "system" | ||
| } | ||
| }, |
There was a problem hiding this comment.
I added this manually, we would need to update lib/tasks/models.rake but I don't have all credentials to do so
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code was mentioning
o3-minibut somehow this model wasn't part of themodels.jsonconfiguration file.I assume it could because it doesn't support the
temperatureparameter, so things had to get slightly adjusted.