Refactor docker and cross-util commands. #794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alexhuszagh
commented
Jun 14, 2022
Alexhuszagh
commented
Jun 14, 2022
Alexhuszagh
commented
Jun 14, 2022
Alexhuszagh
commented
Jun 14, 2022
Alexhuszagh
commented
Jun 14, 2022
Emilgardis
requested changes
Jun 14, 2022
Refactor the internals of the docker module and separate the cross-util commands from the actual binary. Will simplify the internals for adding cross-remote support later.
Alexhuszagh
force-pushed
the
docker_refactor
branch
from
e9bab19 to
96246b2
Compare
Emilgardis
approved these changes
Jun 14, 2022
|
bors r=Emilgardis |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the internals of the docker module and separate the cross-util commands from the actual binary. Will simplify the internals for adding remote container support later.