Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add endpoint logging #190

Merged
merged 20 commits into from
Jul 16, 2024
Merged

Add endpoint logging #190

merged 20 commits into from
Jul 16, 2024

Conversation

skoriop
Copy link
Member

@skoriop skoriop commented Jun 25, 2024

Resolves #183.

  • Add pino logger to the backend
    • Add request logging middleware
    • Add response logging
  • Add TypeORM logging for database queries
  • Add comments and update docs

@skoriop skoriop requested a review from soumitradev June 26, 2024 10:22
@skoriop skoriop marked this pull request as ready for review June 26, 2024 10:23
@skoriop skoriop requested a review from kishan1735 June 27, 2024 22:40
also added docs about bind mount filesystem permissions
Copy link
Member

@soumitradev soumitradev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a code review, but based on the back-and-forth on the Discord, LGTM

@soumitradev
Copy link
Member

Okay I'm dumb I accidentally requested changes

Copy link
Member

@soumitradev soumitradev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a code review, but based on the back-and-forth on the Discord, LGTM

@skoriop skoriop added this pull request to the merge queue Jul 16, 2024
Merged via the queue into master with commit 02131b3 Jul 16, 2024
1 check passed
@skoriop skoriop deleted the add-endpoint-logging branch July 18, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add structured JSON logging to all endpoints, see pino.js
2 participants