Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added search-service endpoints to /edit and /delete endpoints #197

Merged
merged 5 commits into from
Jul 18, 2024
Merged

Added search-service endpoints to /edit and /delete endpoints #197

merged 5 commits into from
Jul 18, 2024

Conversation

NamitBhutani
Copy link
Member

No description provided.

@skoriop skoriop linked an issue Jul 17, 2024 that may be closed by this pull request
Update backend endpoints to add & remove timetables in the search service #195
Closed
skoriop
skoriop requested changes Jul 17, 2024
View reviewed changes
Copy link
Member

@skoriop skoriop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work overall, just some minor changes:

skoriop
skoriop previously approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@skoriop skoriop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skoriop skoriop added the ready Ready to be merged (used by our GitHub Actions pipeline) label Jul 18, 2024
@skoriop skoriop added ready Ready to be merged (used by our GitHub Actions pipeline) and removed ready Ready to be merged (used by our GitHub Actions pipeline) labels Jul 18, 2024
@skoriop skoriop added this pull request to the merge queue Jul 18, 2024
Merged via the queue into master with commit c428a02 Jul 18, 2024
1 check passed
@skoriop skoriop deleted the add-search-service-endpoints branch July 20, 2024 14:59
@skoriop skoriop mentioned this pull request Jul 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skoriop skoriop skoriop approved these changes

Assignees
No one assigned
Labels
ready Ready to be merged (used by our GitHub Actions pipeline)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update backend endpoints to add & remove timetables in the search service
2 participants
@NamitBhutani @skoriop