feat: Add support for ESLint 9 #797
Conversation
There was a problem hiding this comment.
Some rules are DUPLICATED, is it okay to leave them as they are for now?
https://eslint.org/docs/latest/rules#deprecated
flat/lib/typescript.js
Outdated
| "@typescript-eslint/indent": ["warn", 2, { SwitchCase: 1 }], | ||
| // "@stylistic/ts/indent": ["warn", 2, { SwitchCase: 1 }], |
There was a problem hiding this comment.
Why is it currently disabled?
There was a problem hiding this comment.
This was a complete MISS! (thanks for the review🙏).
What I found out is that when I use eslint-plugin-prettier, It is basically disabling these style rules in eslint-config-prettier.
Unfortunately, the rules that have been moved to @Stylistic are not registered in eslint-config-prettier.
So, I changed the ruleset to disable these rules when using eslint-plugin-prettier.
lib/typescript.js
Outdated
| // rules deleted from `recommended` in v8 | ||
| "no-loss-of-precision": "off", | ||
| "@typescript-eslint/no-loss-of-precision": "error", | ||
|
|
||
| // added instead of `@typescript-eslint/ban-types` in v8 | ||
| "@typescript-eslint/no-empty-object-type": "error", | ||
| "@typescript-eslint/no-unsafe-function-type": "error", | ||
| "@typescript-eslint/no-wrapper-object-types": "error", | ||
|
|
||
| // rules added to `recommended` in v8 | ||
| "@typescript-eslint/no-require-imports": "off", | ||
| "no-unused-expressions": "error", | ||
| "@typescript-eslint/no-unused-expressions": "off", | ||
| "@typescript-eslint/prefer-namespace-keyword": "off", |
There was a problem hiding this comment.
How to check the difference in the rule set?
There was a problem hiding this comment.
I basically used the following page as a reference
Also, as for ban-types, the rules have been split into multiple rules, so I have enabled each of the split rules.
flat/lib/react.js
Outdated
| react: reactPlugin, | ||
| "react-hooks": hooksPlugin, | ||
| "jsx-a11y": jsxA11yPlugin, | ||
| "jsx-a11y": fixupPluginRules(jsxA11yPlugin), |
There was a problem hiding this comment.
Is fixupPluginRules necessary?
There was a problem hiding this comment.
Indeed! I used to use it for temporary v9 support, but that is no longer necessary!
I'll delete it!
|
|
||
| // rules deleted from `recommended` in v8 | ||
| "no-loss-of-precision": "off", | ||
| "@typescript-eslint/no-loss-of-precision": "error", |
There was a problem hiding this comment.
It seems that the rule "@typescript-eslint/no-loss-of-precision" has been removed. Is this setting still necessary?
https://typescript-eslint.io/blog/announcing-typescript-eslint-v8/#rule-breaking-changes
typescript-eslint/typescript-eslint#8832
There was a problem hiding this comment.
Thank you very much!
This rule seems to have been deprecated because the eslint rules have been enhanced and the ts-eslint rules are no longer needed, so it looks good to remove it as you pointed out!
c.f. : https://typescript-eslint.io/rules/no-loss-of-precision/
Outline
Added support for eslint v9. Specifically, I did the following.
Details
Update plugins this pakcage is using
"@typescript-eslint/eslint-plugin"and"@typescript-eslint/parser"Changed plugins that are not compatible with eslint v9 to alternative ones
Since
eslint-plugin-importdoes not support eslint v9, we chose to useeslint-plugin-import-x(famous fork ofeslint-plugin-import) instead.Resolve differences in ruleset created by changes in 2.
There are changes in ruleset due to a major version update of
typescript-eslintto v8.Also, some rules were transferred from
typescript-eslintto@stylistic"@typescript-eslint/indent""@typescript-eslint/no-extra-semi"and, these rules are not disabled by eslint-config-prettier, so disable these two rules where eslint-config-prettier is used.
Update test fixture due to API change by v9
The eslint Node.js API has changed since FlatConfig became the default in eslint v9. Therefore, the fixture for rule-set testing was also changed to match this API change.
Update flat config type due to API change by v9
Change
Linter.FlatConfig[]toLinter.Config[].awaitingeslint-plugin-jsx-a11yAdd support for ESLint 9 jsx-eslint/eslint-plugin-jsx-a11y#978→ Now eslint v9 support is complete.(2024/09/10)