Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notifications column to first deck #778

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dsaxton
Copy link
Contributor

@dsaxton dsaxton commented Mar 10, 2025

Default deck for a new user looks like this after the change:

image

I did notice this panic / crash though if I try to click the "add new column" button:

thread 'main' panicked at crates/notedeck_columns/src/app.rs:600:23:
Added more `Strip` cells than were pre-allocated (3 pre-allocated)
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

I get the same on master though so I don't think it's related.

Relates to #599

@jb55
Copy link
Contributor

jb55 commented Mar 10, 2025

looks like there's a bug where columns added this way:

2025-03-10T18:52:48.116051Z ERROR notedeck_columns::ui::timeline: tried to render timeline in column, but timeline was missing

I've noticed this sometimes in other context and was introduced in my Timeline refactor:

fd030f5

I'll use this branch as a failing test case

@dsaxton
Copy link
Contributor Author

dsaxton commented Mar 12, 2025

looks like there's a bug where columns added this way:

2025-03-10T18:52:48.116051Z ERROR notedeck_columns::ui::timeline: tried to render timeline in column, but timeline was missing

I've noticed this sometimes in other context and was introduced in my Timeline refactor:

fd030f5

I'll use this branch as a failing test case

I was noticing those errors too, although just now (after reordering the columns in the default deck for better looks / UX) it crashed without ever hitting those empty timeline errors:

2025-03-12T03:16:09.387538Z  WARN notedeck_columns::app: got unknown eose subid 589a7b8b-b4c3-46b4-86ce-998bacb299cb, 65 tracked subscriptions
2025-03-12T03:16:09.393337Z  WARN notedeck_columns::app: got unknown eose subid 2605e150-7e18-4873-a686-6354dc4e8304, 65 tracked subscriptions
2025-03-12T03:16:09.446901Z  INFO notedeck_columns::app: got contact list from wss://purplepag.es/, updating filter_state to got_remote
2025-03-12T03:16:09.941890Z  INFO notedeck_columns::app: got contact list from wss://nos.lol/, updating filter_state to got_remote
2025-03-12T03:16:11.385878Z  INFO notedeck_columns::app: Getting 23 unknown ids from relays
2025-03-12T03:16:13.596604Z  INFO notedeck_columns::app: Getting 1 unknown ids from relays
2025-03-12T03:16:21.238030Z  INFO notedeck_columns::app: Getting 1 unknown ids from relays
2025-03-12T03:16:46.885859Z ERROR notedeck_columns::timeline: setup_new_timeline: database error: Transaction failed
2025-03-12T03:16:46.886342Z  WARN notedeck_columns::timeline: Skipping since optimization for Universe: number of local notes is less than limit, attempting to backfill.
2025-03-12T03:16:46.886748Z  WARN notedeck_columns::timeline: Skipping since optimization for Universe: number of local notes is less than limit, attempting to backfill.
2025-03-12T03:16:46.887202Z  WARN notedeck_columns::timeline: Skipping since optimization for Universe: number of local notes is less than limit, attempting to backfill.
2025-03-12T03:16:46.887630Z  WARN notedeck_columns::timeline: Skipping since optimization for Universe: number of local notes is less than limit, attempting to backfill.
2025-03-12T03:16:46.888074Z  WARN notedeck_columns::timeline: Skipping since optimization for Universe: number of local notes is less than limit, attempting to backfill.
2025-03-12T03:16:47.048351Z  INFO notedeck_columns::storage::decks: Successfully wrote decks cache to decks_cache.json

thread 'main' panicked at crates/notedeck_columns/src/app.rs:600:23:
Added more `Strip` cells than were pre-allocated (3 pre-allocated)
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants