Skip to content

Replace 'parseCueTime' with 'parseTimeStamp' #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Replace 'parseCueTime' with 'parseTimeStamp' #14

wants to merge 2 commits into from

Conversation

CharlieStras
Copy link

Hi, I found that there is no "parseCueTime" in Video.dev.js(4.12.9) which is the stable version now. So I changed the "parseTimeStamp" function of Video.js and replaced "videojs.TextTrack.prototype.parseCueTime" with it. Maybe this will be better :)

@CharlieStras CharlieStras changed the title Replaced 'parseCueTime' with 'parseTimeStamp' Replace 'parseCueTime' with 'parseTimeStamp' Jun 23, 2015
2. Reset the slider when control panels' value are both correct
@CharlieStras
Copy link
Author

In commit "410cc7d", I added 300ms delay for "keyup" events and reset the slider when control panels' value are both correct.

In the old one, something like this may happen:
screen shot 2015-06-25 at 15 20 14
Start is 0:0:2 and end is 0:0:5

screen shot 2015-06-25 at 15 22 12
Set start to 0:0:10

screen shot 2015-06-25 at 15 23 06
Set end to 0:0:20

Now the start's value and end's value are both correct, but the slider is still set as 0:0:1 to 0:0:20, and the left control panel's second border is still red.

So I reset them as the values change appropriately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant