Allow ^2.0 and ^3.0 of psr/log #127
Conversation
src/lib/PubSub/CloudEvent.php
Outdated
| use LogicException; | ||
|
|
||
| /** | ||
| * Class CloudEvent | ||
| * @package Dapr\PubSub | ||
| */ | ||
| #[Deprecated(since: '1.3.0', replacement: \CloudEvents\V1\CloudEvent::class)] |
There was a problem hiding this comment.
Nice! It may also be worth adding a @deprecated to the docblock so other tools pick it up (like psalm/phpstan) that maybe don't know about phpstorm's attribute.
There was a problem hiding this comment.
Definitely! I'll add that right away.
However I didn't really mean to push the CloudEvent replacement into the same PR as the psr/log updates 😅
|
@withinboredom The psr/log update should now be good to go. I'll send another PR for the CloudEvents replacement |
Codecov Report
@@ Coverage Diff @@
## main #127 +/- ##
============================================
- Coverage 75.99% 73.48% -2.51%
Complexity 562 562
============================================
Files 69 72 +3
Lines 1791 1746 -45
============================================
- Hits 1361 1283 -78
- Misses 430 463 +33
Continue to review full report at Codecov.
|
|
I expect the integration tests to fail to build again, but while I fix them, and you're in the composer.json file, feel free to add yourself to the authors key :) |
|
Finally some public contributions besides fixing typos and updating docs 🔥 :-) |
Signed-off-by: Hendrik Heil <[email protected]>
Signed-off-by: Hendrik Heil <[email protected]>
|
@withinboredom Same here, just added my signature so should be ready for merging. |
Description
This PR seeks to add support for API-compatible versions of psr/log
Issue reference
#126
Checklist