Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate SecretsManager and test new client #99

Merged
merged 2 commits into from
Jul 16, 2021
Merged

Conversation

withinboredom
Copy link
Contributor

Description

This deprecates the SecretManager and adds tests for the new client

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to
implementation.

Please reference the issue this PR: #36

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Tests pass
  • Created/updated tests
  • Extended the documentation

@codecov-commenter
Copy link

Codecov Report

Merging #99 (54c88c7) into main (6fb3015) will increase coverage by 1.40%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #99      +/-   ##
============================================
+ Coverage     66.70%   68.10%   +1.40%     
  Complexity      455      455              
============================================
  Files            59       59              
  Lines          1682     1690       +8     
============================================
+ Hits           1122     1151      +29     
+ Misses          560      539      -21     
Impacted Files Coverage Δ
src/lib/Client/DaprClient.php 53.84% <ø> (ø)
src/lib/SecretManager.php 75.00% <ø> (ø)
src/lib/Client/HttpSecretsTrait.php 100.00% <100.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fb3015...54c88c7. Read the comment docs.

@withinboredom withinboredom merged commit debcd71 into main Jul 16, 2021
@withinboredom withinboredom deleted the refactor/secrets branch July 16, 2021 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants