Added pre-scan verification for excessive scan #234
Conversation
#227 Android API 24 (7.0) introduced an undocomented “feature” that aims on applications that try to start too many scans (5+) in a short time window (30 seconds) by silently (log error only) not starting the scan. More info available here: https://blog.classycode.com/undocumented-android-7-ble-behavior-changes-d1a9bd87d983
|
There is an alternative on how to check for this error but it would need to parse the log on the device. Probably not the most performant but an interesting idea though. |
|
It's not possible to parse Logcat from the app |
|
It is possible but only to parse your own app logcat. Unfortunately the log about excessive scans comes from the system and is not reachable programmatically. |
| import android.support.annotation.Nullable; | ||
| import java.util.Date; | ||
|
|
||
| public class ExcessiveScanCheckerApi18 implements ExcessiveScanChecker { |
There was a problem hiding this comment.
What do you think if the name would suggest what this class does? Basically that it's a pass through.
|
|
||
| @Nullable | ||
| @Override | ||
| public Date suggestDateToRetry() { |
There was a problem hiding this comment.
It's not obvious that the method returning a suggestion is also modifying the state of the checker. I think that this method should idempotent and there should be a method to alter the state.
| return null; | ||
| } | ||
|
|
||
| private int getOldestCheckTimestampIndex() { |
There was a problem hiding this comment.
Something like a fixed size stack seems to be cool https://stackoverflow.com/a/16206356
…TED_SCAN_THROTTLE`.
…_api_24 # Conflicts: # CHANGELOG.md
dariuszseweryn
deleted the
fix/issue_227_undocumented_excessive_scan_api_24
branch
#227
Android API 24 (7.0) introduced an undocomented “feature” that aims on applications that try to start too many scans (5+) in a short time window (30 seconds) by silently (log error only) not starting the scan. More info available here: https://blog.classycode.com/undocumented-android-7-ble-behavior-changes-d1a9bd87d983