Adjusted RxBleDevice.observeConnectionStateChanges() behaviour
#238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tate changes of the actual `BluetoothGatt`. #50 Previously `RxBleDevice.observeConnectionStateChanges()` was emitting immediately the initial state. The state was derived from user’s actions (i.e. `CONNECTING` was emitted right after user has subscribed to `RxBleDevice.establishConnection()`) rather than state in which the `BluetoothGatt` was. This behaviour has been changed to best reflect the state of `BluetoothGatt` at any given time.
uKL
requested changes
Jul 3, 2017
| @@ -48,12 +50,14 @@ public Builder( | |||
| BleConnectionCompat connectionCompat, | |||
| RxBleGattCallback rxBleGattCallback, | |||
| @Named(CONNECT_TIMEOUT) TimeoutConfiguration connectionTimeout, | |||
| BluetoothGattProvider bluetoothGattProvider) { | |||
| BluetoothGattProvider bluetoothGattProvider, | |||
| Action1<RxBleConnection.RxBleConnectionState> connectionStateChangedAction) { | |||
There was a problem hiding this comment.
It's not really declarative that we inject Action1<RxBleConnection.RxBleConnectionState> here. Can we have it wrapped in a custom interface saying that this is a connection state dispatcher?
Looking from a test/user perspective it wouldn't say much about this parameter.
uKL
approved these changes
Jul 4, 2017
…n_state_beahviour_change # Conflicts: # CHANGELOG.md
dariuszseweryn
deleted the
feature/issue_50_device_observe_connection_state_beahviour_change
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#50
Previously
RxBleDevice.observeConnectionStateChanges()was emitting immediately the initial state. The state was derived from user’s actions (i.e.CONNECTINGwas emitted right after user has subscribed toRxBleDevice.establishConnection()) rather than state in which theBluetoothGattwas. This behaviour has been changed to best reflect the state ofBluetoothGattat any given time.